codfrm/nsq_exporter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #8 from lovoo/fix-e2elatency

Browse Source 
Fixes a panic with wrong values in e2elatency
This commit is contained in:
louis
2016-08-09 09:58:12 +02:00
committed by GitHub
parent a863ac9d77 18e4915520
commit 053bd0a68a
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
collector/stats.go
View File

@ -48,6 +48,13 @@ type e2elatency struct {
Percentiles []map[string]float64 `json:"percentiles"` Percentiles []map[string]float64 `json:"percentiles"`
} }
func (e *e2elatency) percentileValue(idx int) float64 {
if idx >= len(e.Percentiles) {
return 0
}
return e.Percentiles[idx]["value"]
}
type client struct { type client struct {
ID string `json:"client_id"` ID string `json:"client_id"`
Hostname string `json:"hostname"` Hostname string `json:"hostname"`

4
collector/stats_channel.go
View File

@ -59,7 +59,7 @@ func ChannelStats(namespace string) StatsCollector {
}, labels), }, labels),
}, },
{ {
val: func(c *channel) float64 { return c.E2eLatency.Percentiles[0]["value"] }, val: func(c *channel) float64 { return c.E2eLatency.percentileValue(0) },
vec: prometheus.NewGaugeVec(prometheus.GaugeOpts{ vec: prometheus.NewGaugeVec(prometheus.GaugeOpts{
Namespace: namespace, Namespace: namespace,
Name: "e2e_latency_99p", Name: "e2e_latency_99p",
@ -67,7 +67,7 @@ func ChannelStats(namespace string) StatsCollector {
}, labels), }, labels),
}, },
{ {
val: func(c *channel) float64 { return c.E2eLatency.Percentiles[1]["value"] }, val: func(c *channel) float64 { return c.E2eLatency.percentileValue(1) },
vec: prometheus.NewGaugeVec(prometheus.GaugeOpts{ vec: prometheus.NewGaugeVec(prometheus.GaugeOpts{
Namespace: namespace, Namespace: namespace,
Name: "e2e_latency_95p", Name: "e2e_latency_95p",