addressed nit picks

This commit is contained in:
Atharva Mulmuley 2021-04-28 17:43:56 +05:30
parent 579411ab66
commit 269939dbae
4 changed files with 4 additions and 4 deletions

View File

@ -25,7 +25,7 @@ jobs:
- uses: atharvamulmuley/k8s-set-context@cluster-connect-2 - uses: atharvamulmuley/k8s-set-context@cluster-connect-2
with: with:
method: spn method: SPN
cluster-type: 'arc' cluster-type: 'arc'
creds: '${{ secrets.AZURE_CREDS }}' creds: '${{ secrets.AZURE_CREDS }}'
cluster-name: arcaction cluster-name: arcaction

View File

@ -23,7 +23,7 @@ In both these approaches it is recommended to store these contents (kubeconfig f
</thead> </thead>
<tr> <tr>
<td><code>method</code><br/>Method</td> <td><code>method</code><br/>Method</td>
<td>(Optional) Acceptable values: kubeconfig/service-account/spn. Default value: kubeconfig</td> <td>(Optional) Acceptable values: kubeconfig/service-account/SPN. Default value: kubeconfig</td>
</tr> </tr>
<tr> <tr>
<td><code>kubeconfig</code><br/>Kubectl config</td> <td><code>kubeconfig</code><br/>Kubectl config</td>

View File

@ -7,7 +7,7 @@ inputs:
required: true required: true
default: 'generic' default: 'generic'
method: method:
description: 'Acceptable values: kubeconfig or service-account or spn' description: 'Acceptable values: kubeconfig or service-account or SPN'
required: true required: true
default: 'kubeconfig' default: 'kubeconfig'
kubeconfig: kubeconfig:

View File

@ -52,7 +52,7 @@ async function getAzureAccessToken(servicePrincipalId, servicePrincipalKey, tena
export async function getArcKubeconfig(): Promise<string> { export async function getArcKubeconfig(): Promise<string> {
try { try {
let method = core.getInput('method'); let method = core.getInput('method');
if (method != 'service-account' && method != 'spn'){ if (method != 'service-account' && method != 'SPN'){
throw Error("Supported methods for arc cluster are 'service-account' and 'spn'."); throw Error("Supported methods for arc cluster are 'service-account' and 'spn'.");
} }